monicahq/monica

Create a command to execute all commands that we need to run before pushing final commit to a PR

Open

#1,158 建立於 2018年4月12日

在 GitHub 查看
 (1 留言) (0 反應) (1 負責人)PHP (24,641 star) (2,464 fork)batch import
feature requesthelp wantedproductivity tools

描述

Each time we need to push our final commit to a PR, we need to

  • php artisan lang:generate
  • npm run prod

And sometimes other stuff too.

Perhaps we could create a command php artisan finalize:pr or something that would do that for us.

貢獻者指南

技術棧
phpjavascript
領域
clideveloper experience
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
2
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
half day
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
blocked
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Basic Laravel structureFamiliarity with Artisan commands
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
60
研究方向
The issue requests a new Artisan command that runs `php artisan lang:generate` and `npm run prod`. To implement, look at existing commands in the `app/Console/Commands` directory to understand the pattern. For executing other Artisan commands, use the `Artisan::call()` facade. The command should be registered in `app/Console/Kernel.php`. Also, note that the command could accept additional arguments to run other steps. The assignee is currently assigned, so coordinate with them before starting.
Create a command to execute all commands that we need to run before pushing final commit to a PR · monicahq/monica#1158 | Good First Issue