miraclx/freyr-js

Transcoding to 320kbps is useless

Open

#440 建立於 2023年2月24日

在 GitHub 查看
 (4 留言) (7 反應) (0 負責人)JavaScript (2,279 star) (154 fork)user submission
enhancementhelp wanted

描述

Because the audio is sourced from YouTube the highest bitrate audio available is 256kbps. Transcoding the already compressed 256kbps audio to 320 kbps AAC will only result in loss of information as AAC is a lossy codec and transcoding is generally an at least somewhat lossy process. I suggest instead downloading the maximum of 256kbps and leaving it be, or if the user specifies a lower bitrate downloading YouTube's copy of the audio at that bitrate (which much of the time does exist). If no such version can be found, download the 256kbps copy and transcode to the lower bitrate.

貢獻者指南

技術棧
javascript
領域
clitooling
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
fresh
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
JavaScriptaudio codecs understanding
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
60
研究方向
Examine the download logic in the source code (likely in src/ or lib/), focusing on how audio bitrate is selected and transcoded. Look for the code that handles YouTube audio fetching and any flags like bitrate. Then modify the logic to avoid transcoding to 320kbps when input is 256kbps, either by keeping original or transcoding down if a lower bitrate is requested. Check if there are tests for transcoding and add a test case verifying no unnecessary transcoding.