mike-north/ember-cli-materialize

[Bug] Parallax doesn't tear its self down completely

Open

#85 建立於 2015年4月24日

在 GitHub 查看
 (1 留言) (0 反應) (0 負責人)JavaScript (305 star) (117 fork)batch import
bugfixed in materialize-v1.0.0help wantedv0

描述

The following Materialize code registers various listeners, which should be torn down in the component's willDestroyElement hook

this.$('.parallax').parallax();

Potentially this will entail adding some "cleanup" methods to the Materialize project, which can then be called by this component

貢獻者指南

技術棧
javascriptcsshtml
領域
frontend
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Understanding of Ember.js component lifecycleKnowledge of jQuery event handling
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
40
研究方向
First, locate the Ember component file that initializes the parallax (likely in addon/components). Check if there is already a willDestroyElement hook and what cleanup is missing. Then, look at the Materialize parallax plugin source (typically in vendor or bower components) to see if it provides a destroy method. If not, the fix may involve adding a custom cleanup function that removes event listeners and the parallax instance. Review the single comment on the issue for any additional context.