miickel/gulp-angular-templatecache

Leading slash added to filenames under gulp 4

Open

#164 建立於 2018年10月28日

在 GitHub 查看
 (18 留言) (5 反應) (0 負責人)JavaScript (533 star) (97 fork)batch import
help wanted

描述

Calling this package with gulp 4 erroneously results in template filenames with leading separators.

This seems to be due to the breaking change in vinyl, where internal path records such as file.base are now normalized: https://github.com/gulpjs/vinyl/commit/9ae7cd10c5423cbad9d38fc6c99960c62ac2f429#diff-c49ce3c4dfcfa830e06789881dd4d5d4 That change breaks the following code: url = path.join(root, file.path.replace(base || file.base, ''));

It is the root cause of #153

I posted a workaround in the other issue, but I'll see if I can cook something up that's compatible with all vinyl versions instead

貢獻者指南

技術棧
javascriptnodejsangular
領域
frontendbuild systemtooling
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
gulpvinylNode.jsAngularJS
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
65
研究方向
Examine the code around `url = path.join(root, file.path.replace(base || file.base, ''));` in the plugin's main file. Understand the change in vinyl's normalization of `file.base` (see https://github.com/gulpjs/vinyl/commit/9ae7cd10c5423cbad9d38fc6c99960c62ac2f429#diff c49ce3c4dfcfa830e06789881dd4d5d4). The fix should handle both normalized and non normalized paths. Consider using `file.relative` or checking if `file.path` already contains `root`. Also test with different versions of gulp and vinyl to avoid regressions.