miguel-perez/smoothState.js

Ajax success method issue

Open

#229 建立於 2015年11月5日

在 GitHub 查看
 (4 留言) (1 反應) (0 負責人)CSS (4,433 star) (515 fork)batch import
bughelp wanted

描述

Hello,

My implementation has been choking on line 375 letting me know that $.ajax(settings).success(...) is not a function. After researching it seems that the success / error / complete callbacks can be defined in the settings object but there is no such function, the closest being done().

So I changed the source code to settings.success = function(...) and the same for error and complete, before calling $.ajax(settings).

It seems to be working. But not being a developper I'm not really sure that would be the appropriate fix...

貢獻者指南

技術棧
javascript
領域
frontend
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
2
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
under 1 hour
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
mostly clear
前置要求
basic jQueryJavaScript
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
80
研究方向
Investigate the issue in the smoothState.js repository. The user reports that line 375 in the main JavaScript file uses $.ajax(settings).success(), which is deprecated since jQuery 1.8. The suggested fix is to use .done() instead. However, confirm that the library still supports older jQuery versions and check if any other deprecated methods are used elsewhere. Also, verify that the current maintainer is active and whether a PR would be welcome.