miguel-perez/smoothState.js

storePageIn() fails to find container in new doc if nested

Open

#193 建立於 2015年7月8日

在 GitHub 查看
 (8 留言) (0 反應) (0 負責人)CSS (4,433 star) (515 fork)batch import
bughelp wanted

描述

Nesting the container even one level under the body tag prevents storePageIn() from find it.

<body>
    <div>
        <article id="js-smoothstate-content">
            <h1>TEST CONTENT</h1>
        </article>
    </div>
</body>

The filter() function won't find the container id (Chrome v43):

storePageIn: function (object, url, doc, id) {
    /../
    object[url] = { // Content is indexed by the url
        /../
        html: $newDoc.filter('#' + id), // Stores the contents of the page
    }; 
}

Consider using .find() instead?

貢獻者指南

技術棧
javascript
領域
frontend
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
2
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
under 1 hour
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
basic JavaScriptjQuery
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
80
研究方向
The issue reports that storePageIn() uses .filter() to find the container element, which fails when the container is nested inside another element. The suggested fix is to use .find() instead. Check the source code in smoothState.js around the storePageIn function (likely lines 100-150) and verify that changing $newDoc.filter('#' + id) to $newDoc.find('#' + id) resolves the issue without breaking other functionality. Also ensure that the id is correctly scoped and that no other parts of the code rely on the .filter() behavior.