microsoft/perfview

Freeze processing in EventPipeEventSource if uncaught exception is thrown in callback.

Open

#1,290 建立於 2020年10月15日

在 GitHub 查看
 (0 留言) (0 反應) (0 負責人)C# (3,819 star) (687 fork)batch import
bughelp wanted

描述

Environment

  • Microsoft.Diagnostics.Tracing.TraceEvent: 2.0.61
  • Microsoft.Diagnostics.NETCore.Client: 0.2.141901
  • EventPipe sender app and receiver app's TFM: net5.0-rc2

Steps to reproduce

  1. run app which produce EventSource event periodically
  2. start EventPipe session by DiagnosticClient
  3. create EventPipeEventSource from event stream
  4. set callback to DynamicEventParser.All
    • Exception will be thrown in callback
  5. start processing

full test code is uploaded to gist

Expected result

callback is invoked periodicaly, or at least terminate event processing when EventPipeEventSource.StopProcessing is called.

Actual result

callback was never invoked again, and EventPipeEventSource.Process never returned, even if EventPipeEventSource.StopProcessing was called.

貢獻者指南

技術棧
csharp
領域
observabilityperformance
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
half day
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
needs investigation
前置要求
C#.NETEventPipe
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
20
研究方向
Investigate the EventPipeEventSource class in the Microsoft.Diagnostics.Tracing.TraceEvent library to understand how callbacks are invoked and how exceptions are handled. The issue shows that an uncaught exception in the callback causes the event loop to freeze. Look for try catch blocks around callback invocations and ensure exceptions are caught to avoid freezing. Also check the StopProcessing mechanism to ensure it can interrupt a frozen loop.