microsoft/microsoft-ui-xaml

Icon on MenuFlyoutItem within a dark container turns black on pointer exit (with OS in light mode theme color)

Open

#5,381 建立於 2021年7月7日

在 GitHub 查看
 (10 留言) (0 反應) (0 負責人)C# (5,815 star) (659 fork)batch import
area-Menusbughelp wantedreact-native-windowsteam-Controls

描述

Steps to reproduce the bug

  1. Clone or download https://github.com/lyahdav/CppWinRtUwpSandbox
  2. Run solution https://github.com/lyahdav/CppWinRtUwpSandbox/blob/main/cppwinrt/Calendar.sln
  3. Click MenuFlyout button
  4. Hover over the 2nd menu item and then hover away from it

Expected behavior Icon for the menu item stays white. Instead it changes to black.

Screenshots

https://user-images.githubusercontent.com/359157/124684321-b002fd00-de83-11eb-91cb-c3d780cf5215.mov

Version Info Windows 10 21H1 / 19043.928 Islands

Device form factor Saw the problem?
Desktop Yes
Xbox
Surface Hub
IoT

Additional context The relevant code is here: https://github.com/lyahdav/CppWinRtUwpSandbox/blob/main/SharedContent/cppwinrt/MainPage.cpp#L65-L91. I have two workarounds there as well:

  1. Reload the icon on PointerExited. This isn't ideal since it flickers.
  2. Explicitly set BitmapIcon.Foreground(nullptr).

貢獻者指南

技術棧
csharp
領域
frontenddesktop
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
half day
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
fresh
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Basic knowledge of WinUIFamiliarity with XAML stylingUnderstanding of pointer eventsWindows 10 development setup
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
70
研究方向
Investigate the default style for MenuFlyoutItem and BitmapIcon in the WinUI repository. The issue likely involves a missing or incorrect theme resource binding for the icon foreground when the pointer exits. Check the generic.xaml file for relevant templates. Also review the comments for any additional context or potential fixes that were discussed.