microsoft/microsoft-ui-xaml

Control Styles should be named

Open

#3,735 建立於 2020年12月1日

在 GitHub 查看
 (16 留言) (1 反應) (0 負責人)C# (5,815 star) (659 fork)batch import
area-Stylinghelp wantedteam-Controlswct

描述

While investigating this, I noticed an issue for this that is a complete show stopper: there is no way to override the default TabViewItem style. Unlike some other controls, the TabViewItem does not follow the pattern of:

<Style TargetType="ControlName" BasedOn="DefaultControlNameStyle"/>

<Style x:Key="DefaultControlNameStyle" TargetType="ControlName">
...
</Style>

but rather just exposes the complete template as the default style leaving users with no choice of easily overriding the default style. However that is something that we would need for this feature to be easily usable. @ranjeshj @stmoy @StephenLPeters Is that something we can change to make that customization easier?

@michael-hawker FYI

Originally posted by @chingucoding in https://github.com/microsoft/microsoft-ui-xaml/issues/2587#issuecomment-732463534

貢獻者指南

技術棧
csharp
領域
desktopfrontend
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-2 days
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
XAML stylingWinUI controlsC# basics
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
30
研究方向
Investigate the current default style pattern for TabViewItem and other controls in the repository. Identify where default styles are defined (likely in generic.xaml). Propose a change to follow the 'DefaultControlNameStyle' pattern as used by other controls, ensuring backward compatibility. Consult maintainers @ranjeshj, @stmoy, @StephenLPets for guidelines on naming conventions.
Control Styles should be named · microsoft/microsoft-ui-xaml#3735 | Good First Issue