DidChangeConfigurationParams should contain a workspace URI
#457 建立於 2018年4月22日
倉庫指標
- Star
- (12,810 star)
- PR 合併指標
- (平均合併 19小時 29分鐘) (30 天內合併 12 個 PR)
描述
With 3.6.0 the protocol specification got multi-workspace support, however the workspace/didChangeConfiguration notification is still specced for single workspace roots. Often there is project/workspace specific configuration which should also trigger the workspace/didChangeConfiguration notification, however the server has no way of knowing for which workspace this new configuration applies and could just apply it to all workspaces which may yield in wrong future behaviour of the server.
Adding the workspace URI to DidChangeConfigurationParams is an easy way to make servers aware of workspace specific configuration without breaking backwards compatibility. If the field is unset/empty the server can just treat it like it did before such a change and if the server doesn't even support it, it will just treat it like before.