microsoft/cpprestsdk

Inconsistent encoding when comparing oauth1_config::m_token in oauth1_config::token_from_redirected_uri()

Open

#5 建立於 2015年10月13日

在 GitHub 查看
 (1 留言) (0 反應) (0 負責人)C++ (7,596 star) (1,670 fork)batch import
bughelp wanted

描述

Hi,

I am getting an exception at final stage of authentication process - "redirected URI parameter 'oauth_token'='...' does not match temporary token='...'.".

Probably I found why it fails.

  1. When temporary token is received it is stored to oauth1_config::m_token as URI DECODED. See https://github.com/Microsoft/cpprestsdk/blob/master/Release/src/http/oauth/oauth1.cpp:319

  2. After redirection, we get access token by calling oauth1_config::token_from_redirected_uri(uri). Which throws an exception, because it tries to compare token stored at step 1) and URI ENCODED token from redirected uri.

The possible workflow: decode redirected uri manually for oauth1_config::token_from_redirected_uri. Is that correct solution?

Regards, Vladimir.

貢獻者指南

技術棧
cpprest api
領域
backendapi
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
half day
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
mostly clear
前置要求
C++ basicsOAuth1 understandingURI encoding concepts
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
30
研究方向
Examine oauth1.cpp line 319 and the token from redirected uri function to trace the encoding mismatch. The bug occurs because the temporary token is stored URI decoded, but the redirected URI token is URI encoded, leading to a comparison failure. Consider either decoding the redirected token or encoding the stored token before comparison. Check for any comments or linked issues in the repository for additional context.