microsoft/Terminal

Move u8State from WriteConsoleAImpl to SCREEN_INFORMATION

開放

#6,982 建立於 2020年7月20日

 (1 則留言) (0 個反應) (0 位負責人)C++ (9,275 個分叉)batch import
Area-CodeHealthHelp WantedIssue-TaskPriority-3Product-Conhost

倉庫指標

星標
 (103,173 顆星)
PR 合併指標
 (平均合併 27天 19小時) (30 天內合併 24 個 PR)

描述

Environment

Windows build number: [run `[Environment]::OSVersion` for powershell, or `ver` for cmd] 10.0.19041.388
Windows Terminal version (if applicable): 1.0.1811.0 + recent preview

In #4493 @miniksa pointed out that the state should be a member of SCREEN_INFORMATION rather than a static variable in WriteConsoleAImpl. Refer to https://github.com/microsoft/terminal/pull/4493#discussion_r389024806 In the current code base it's still in WriteConsoleAImpl though. https://github.com/microsoft/terminal/blob/d0ff5f6b5e7687c438e0a8b120280be307eda778/src/host/_stream.cpp#L1107 Since I closed the PR I just don't want this information to get lost.

貢獻者指南