microsoft/Terminal
Investigate include order issue with `InputBuffer`, `readData`
開放
#4,262 建立於 2020年1月16日
Area-CodeHealthHelp WantedIssue-TaskPriority-3Product-Conhost
倉庫指標
- 星標
- (103,173 顆星)
- PR 合併指標
- (平均合併 27天 19小時) (30 天內合併 24 個 PR)
描述
Found in #4213.
I had to fwddecl InputBuffer, because I think there's a include order problem with in InputBuffer.hpp and readData.hpp.
readData.hpp uses InputBuffer in a bunch of places, but doesn't include it first
InputBuffer.hpp includes readData.hpp before it defines InputBuffer
So if you try to
#include ".../host/inputBuffer.hpp"
You'll get a compilation error, because it'll include readData, which will assume InputBuffer is defined, which it isn't yet.