microsoft/Terminal

Code Health: Update existing winrt properties to use `GETSET_PROPERTY` when possible

Open

#3,988 建立於 2019年12月17日

在 GitHub 查看
 (0 留言) (0 反應) (0 負責人)C++ (3,212 fork)batch import
Area-CodeHealthHelp WantedIssue-TaskProduct-Terminal

倉庫指標

Star
 (35,764 star)
PR 合併指標
 (平均合併 27天 19小時) (30 天內合併 24 個 PR)

描述

Pretty self explanatory. Classes with a bunch of


    uint32_t TerminalSettings::DefaultForeground()
    {
        return _defaultForeground;
    }

    void TerminalSettings::DefaultForeground(uint32_t value)
    {
        _defaultForeground = value;
    }

Is an enormous amount of boilerplate we don't need.

GETSET_PROPERTY(uint32_t, DefaultForeground, DEFAULT_FOREGROUND_WITH_ALPHA);

is better.

貢獻者指南