microsoft/Terminal

Let Terminal auto-detect a busted `AutoRun` value for CMD

Open

#15,658 建立於 2023年7月5日

在 GitHub 查看
 (2 留言) (0 反應) (0 負責人)C++ (3,212 fork)batch import
Area-TerminalConnectionArea-UserInterfaceHelp WantedIssue-TaskProduct-Terminal

倉庫指標

Star
 (35,764 star)
PR 合併指標
 (平均合併 27天 19小時) (30 天內合併 24 個 PR)

描述

CMD has this magic AutoRun reg key that's a gigantic footgun.

  • HKEY_LOCAL_MACHINE\Software\Microsoft\Command Processor\AutoRun
  • HKEY_CURRENT_USER\Software\Microsoft\Command Processor\AutoRun

Basically, if someone writes a bad value to that, it can mess up CMD.exe real bad. As a real life example: https://github.com/conda/constructor/pull/521

We attempted to patch this in Windows 11. But we'll surely be unable to backport that. While we're maintaining Windows 10 support, it might be nice to return a specific warning for this in Terminal. Something like:

if (profileGuid == {cmd} && error == 1 && reg query ....) { write("Hey your AutoRun value might be busted. Go check these reg keys:"); }

(for discussion. We can always just say meh, since we did fix this for cmd.exe)

貢獻者指南