micrometer-metrics/micrometer

DNS, SSL, and TCP metrics for Apache HttpClient

Closed

#1,617 建立於 2019年10月1日

在 GitHub 查看
 (5 留言) (0 反應) (1 負責人)Java (4,220 star) (935 fork)batch import
enhancementhelp wantedinstrumentationmodule: micrometer-core

描述

Add metrics for:

  1. DNS resolution time (inject custom DnsResolver, delegating to the user-provided resolver, and timing).
  2. SSL handshake time (inject SSLConnectionSocketFactory, delegating).
  3. TCP connect time (also in custom SSLConnectionSocketFactory).

Apply these on custom PoolingHttpClientConnectionManager.

Feedback suggests that DNS resolution/SSL handshake can go up dramatically in noisy neighbor situations.

Originally posted by @jkschneider in https://github.com/micrometer-metrics/micrometer/issues/533#issuecomment-446713248

貢獻者指南

技術棧
java
領域
observability
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
4
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
3-5 days
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
JavaApache HttpClientMicrometerSSL/TLS basics
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
35
研究方向
Investigate injecting custom DnsResolver and SSLConnectionSocketFactory into PoolingHttpClientConnectionManager. Review Apache HttpClient documentation for hooks. Examine existing Micrometer instrumentation patterns for timing using Timer. Consider the noisy neighbor scenario mentioned in the issue. Look at the original comment by jkschneider for context.
DNS, SSL, and TCP metrics for Apache HttpClient · micrometer-metrics/micrometer#1617 | Good First Issue