micro-analytics/micro-analytics-cli

Connection leaks in adapter tests

Open

#75 建立於 2017年6月29日

在 GitHub 查看
 (0 留言) (1 反應) (0 負責人)JavaScript (52 fork)batch import
adapter-testshelp wanted

倉庫指標

Star
 (738 star)
PR 合併指標
 (30 天內沒有已合併 PR)

描述

The adapter tests does not close connection correctly resulting in tests for the redis adapter never quitting.

The problem is the at the moment is call init should not throw. Overwrites the connections with new one and then when the tests closes connection in afterEach the connection created in beforeEach is not closed.

I think it would be a good thing to require adapter.close() and handle the closing of database connections in the adapter utils.

貢獻者指南