micro-analytics/micro-analytics-cli

Connection leaks in adapter tests

Open

#75 建立於 2017年6月29日

在 GitHub 查看
 (0 留言) (1 反應) (0 負責人)JavaScript (738 star) (52 fork)batch import
adapter-testshelp wanted

描述

The adapter tests does not close connection correctly resulting in tests for the redis adapter never quitting.

The problem is the at the moment is call init should not throw. Overwrites the connections with new one and then when the tests closes connection in afterEach the connection created in beforeEach is not closed.

I think it would be a good thing to require adapter.close() and handle the closing of database connections in the adapter utils.

貢獻者指南

技術棧
javascriptnodejsredis
領域
backendtestingdatabase
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
mostly clear
前置要求
Node.js basicsTesting with JestRedis basics
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
40
研究方向
Examine the adapter test files, likely located in a 'tests/' or 'test/' directory. Focus on the 'beforeEach' and 'afterEach' hooks to identify where connections are not being closed. The suggestion in the issue is to implement an 'adapter.close()' method and ensure it is called in the test teardown. Check if the repository has any recent activity or maintainer responses to gauge current maintenance status.