mholt/PapaParse

preview + step never completes

Open

#618 建立於 2019年1月21日

在 GitHub 查看
 (3 留言) (3 反應) (0 負責人)JavaScript (11,877 star) (1,157 fork)batch import
help wanted

描述

The discussion (in #352) and the docs indicate that the meta.truncated value should become true when the last row to preview is parsed. But it doesn't it remains false and complete is never called. This means short of keeping your own counter there is no way to know that preview has completed.

To repro:

  • Go to the demo.
  • Select local file.
  • check Stream option.
  • Set preview to any positive non-zero value
  • Click parse
  • Nothing ever shows up in the console

貢獻者指南

技術棧
javascript
領域
data
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Familiarity with PapaParse's streaming API
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
60
研究方向
Investigate the step callback implementation in PapaParse's source code. Look at how `meta.truncated` is set when using the preview option. Review the discussion in issue #352 for expected behavior. Implement the fix to set `meta.truncated = true` when the preview row limit is reached and ensure the complete callback is called.