metricsgraphics/metrics-graphics

Respect custom elements on domain computation

Open

#899 建立於 2018年8月19日

在 GitHub 查看
 (2 留言) (0 反應) (0 負責人)JavaScript (7,262 star) (524 fork)batch import
good first issue

描述

I cannot get my large confidence band to fit in the graph. It is cut by the frame itself. Image attached. image

貢獻者指南

技術棧
javascript
領域
frontend
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
half day
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
mostly clear
前置要求
basic JavaScriptfamiliarity with D3 or visualization libraries
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
30
研究方向
The issue concerns confidence bands being cut off by the graph frame. Investigate how the domain (y axis range) is computed for custom elements like confidence bands. Likely located in source files handling scales or domain calculations, e.g., src/js/processors/ or src/js/scales/. Check if the domain computation ignores the extent of custom elements. A fix might involve extending the domain to include all data elements, including custom bands.
Respect custom elements on domain computation · metricsgraphics/metrics-graphics#899 | Good First Issue