metricsgraphics/metrics-graphics

When max_y or min_y is set, the chart line sometimes curves in such a way that peaks are invisible

Open

#823 建立於 2018年2月27日

在 GitHub 查看
 (4 留言) (0 反應) (0 負責人)JavaScript (7,262 star) (524 fork)batch import
bughelp wanted

描述

Steps to reproduce

Download and open this HTML document

Actual result

Screenshot

Expected result

The chart should look something like this (achieved by removing max_y):

貢獻者指南

技術棧
javascript
領域
frontend
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
JavaScriptSVG path rendering
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
45
研究方向
Investigate the chart line rendering logic in the repository, particularly how max y and min y affect the y scale and clipping. The provided HTML reproduction demonstrates the issue; check the source code for line drawing (likely in a file like 'src/js/charts/line.js'). Look for any existing comments or issues mentioning similar problems. No linked PRs or assignees, so the issue is open for contribution.
When max_y or min_y is set, the chart line sometimes curves in such a way that peaks are invisible · metricsgraphics/metrics-graphics#823 | Good First Issue