metosin/malli

malli.transform/-interceptor doesn’t support emptly-ish ?interceptor

Open

#596 建立於 2021年12月17日

在 GitHub 查看
 (2 留言) (0 反應) (0 負責人)Clojure (1,724 star) (237 fork)batch import
bughelp wanted

描述

https://github.com/metosin/malli/blob/152af3a3f8d59cca37a597b2403111bafbdee6ee/src/malli/transform.cljc#L36-L42

Hi,

I’m hitting a corner case with malli transform. I’m still trying to figure out why I’m hitting that corner case and what I can do to avoid that, but I think there’s also a robustness improvement that’s possible in malli.

When the keep function returns an empty list, the reduce function calls the anonymous function on line 38 with no arguments, and this fails.

One possible fix would be to make the anonymous function multi-arity and make it return nil when called with no arguments. Another possible fix would be to check the return value of keep, and only proceed with reducing it if it is a non-empty-list.

貢獻者指南

技術棧
無
領域
backend
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Clojure knowledgeBasic understanding of reduce
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
60
研究方向
Look at the file src/malli/transform.cljc lines 36-42. The anonymous function passed to reduce is called with no arguments when `keep` returns an empty list, causing a failure. Two possible fixes are suggested: make the anonymous function multi arity to return nil when called with no arguments, or check the return value of `keep` and only reduce if it is non empty. Review the surrounding code and choose the simpler approach.