mesonbuild/meson

Report the reason for failure of install script

Open

#2,329 建立於 2017年9月16日

在 GitHub 查看
 (4 留言) (1 反應) (0 負責人)Python (4,978 star) (1,465 fork)batch import
bughelp wanted

描述

When an install script fails, there is no indication as to why.

https://github.com/mesonbuild/meson/blob/c63aa0372b7acd8f6a094ca240eb39c8aab646cf/mesonbuild/scripts/meson_install.py#L262-L268

Meson should either log the stdout/stderr of the scripts or print it on failure.

貢獻者指南

技術棧
pythonshell
領域
build system
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
2
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Basic PythonMeson install script structure
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
75
研究方向
The issue is to log stdout/stderr of install scripts on failure. The relevant code is in mesonbuild/scripts/meson install.py around lines 262-268. Currently, the exit code is checked but no output is captured. Implementation should capture subprocess output and print it upon failure. The change is localized and well defined.
Report the reason for failure of install script · mesonbuild/meson#2329 | Good First Issue