mesonbuild/meson

vcs_tag() error output should be silenced if fallback is specified

已關閉

#2,240 建立於 2017年8月23日

 (12 則留言) (0 個反應) (0 位負責人)Python (1,465 個分叉)batch import
bughelp wanted

倉庫指標

星標
 (4,978 顆星)
PR 合併指標
 (平均合併 139天 13小時) (30 天內合併 51 個 PR)

描述

meson's vcs_tag function is very useful but the fact that it always generates error output if no annotated tag matching the current git revision is found is... unnecessary.

We use actual git revisions as our version numbers for intermediate releases, so we provide the output of git rev-parse HEAD as the value of the fallback parameter to vcs_tag. That works great, but each time meson complains about no annotated tags:

ninja -C debug
ninja: Entering directory `debug'
[1/4] Generating GitVersion.cpp with a custom command.
fatal: No annotated tags can describe 'e5c806c6a0fc0380637b955b018485ccd1214ddd'.
However, there were unannotated tags: try --tags.

If a fallback is provided, I think that output should be silenced.

貢獻者指南