vcs_tag() error output should be silenced if fallback is specified · mesonbuild/meson#2240

(12 留言) (0 反應) (0 負責人)Python (4,978 star) (1,465 fork)batch import

bughelp wanted

描述

meson's vcs_tag function is very useful but the fact that it always generates error output if no annotated tag matching the current git revision is found is... unnecessary.

We use actual git revisions as our version numbers for intermediate releases, so we provide the output of git rev-parse HEAD as the value of the fallback parameter to vcs_tag. That works great, but each time meson complains about no annotated tags:

ninja -C debug
ninja: Entering directory `debug'
[1/4] Generating GitVersion.cpp with a custom command.
fatal: No annotated tags can describe 'e5c806c6a0fc0380637b955b018485ccd1214ddd'.
However, there were unannotated tags: try --tags.

If a fallback is provided, I think that output should be silenced.

貢獻者指南

技術棧: pythonshell
領域: build systemtooling
議題類型: feature
難度: 2
預計時間: 1-3 hours
活動狀態: stale
清晰度: clear
前置要求: Basic understanding of Meson build systemPython scripting
新手友善度: 75
研究方向: Locate the implementation of the vcs tag function in the Meson source code (likely in mesonbuild/interpreter.py or a similar module). Identify where the git command is executed and its output captured. Determine the condition under which a fallback is provided. Modify the code to suppress stderr output from the git command when a fallback is specified. Refer to the existing error handling patterns in the codebase, such as quiet flags on other commands. No linked PRs or recent comments provide a solution, so the task is to implement the feature as described.