mesonbuild/meson

Add a mechanism to add prefix/suffixes to configuration files

Open

#1,492 建立於 2017年3月22日

在 GitHub 查看
 (3 留言) (0 反應) (0 負責人)Python (4,978 star) (1,465 fork)batch import
enhancementhelp wanted

描述

Right now, with configure_file() if the input: kwarg is not set, we just dump the entire configuration. This has the advantage of not having to maintain a duplicate list of defines (one in meson.build, another in config.h.in) and is less error-prone.

However, this leaves a gap: sometimes the config.h is mostly generated, but has a few static defines in it. We should implement a way to also add these to the generated config.h. There are two ways to implement this:

  1. Add prefix: and suffix: kwargs to configure_file()

  2. Add a new token type #meson_dump_configuration (or similar) that can be put in config.h.meson that will dump the configuration_data() object in that place

The latter has the advantage of being more flexible, and the former has the advantage of having all the defines in one place (in meson.build).

貢獻者指南

技術棧
python
領域
build system
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
3-5 days
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Familiarity with Meson build systemPython experience
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
25
研究方向
The issue proposes two approaches: adding `prefix:` and `suffix:` kwargs to `configure file()`, or introducing a `#meson dump configuration` token in config files. To implement, study the existing `configure file()` implementation in `mesonbuild/interpreter.py` and the `configuration data()` object. No linked PRs exist, so work should start from scratch. The maintainers have not clarified preference, so the contributor should choose based on flexibility and codebase consistency.
Add a mechanism to add prefix/suffixes to configuration files · mesonbuild/meson#1492 | Good First Issue