meilisearch/MeiliSearch

Make sure payloads are effectively deleted on error

Open

#6,048 建立於 2025年12月11日

在 GitHub 查看
 (2 留言) (0 反應) (0 負責人)Rust (20,887 star) (733 fork)batch import
Internal workaffects costsbuggood first issue

描述

We found out that some payloads are not removed from the disk when an error occurs before we are able to put them in the FileStore. I would suggest we should create a temporary temporary file and extract it at the last moment.

Originally posted by @Kerollmops in https://github.com/meilisearch/meilisearch/pull/6000#discussion_r2602149151

貢獻者指南

技術棧
rust
領域
backenddatabase
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
fresh
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
mostly clear
前置要求
Rustfile I/O
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
45
研究方向
The issue references a discussion in PR #6000 where a suggestion was made to create a temporary temporary file and extract it at the last moment to ensure payloads are deleted on error. Investigate the current file storage implementation, particularly the FileStore and how files are managed. Look into creating an intermediate temp file that is only moved to the final location after successful extraction. Ensure that errors during the move or extraction are handled to avoid leftover files. The existing code can be found in the 'file store' module.