Change key actions to be bitflags · meilisearch/MeiliSearch#4645

(11 留言) (0 反應) (0 負責人)Rust (20,887 star) (733 fork)batch import

good first issuemaintenance

描述

Currently, the Meilisearch action keys are single numbers and therefore cannot be combined. It's not possible to OR them NOT them. I needed to do a basic documents.add | documents.delete for the edit documents by using a function feature.

We must use bitflags to define those actions and be able to combine them. We could have 32 or 64 different combinable actions. We already use this library in heed and it works very well.

貢獻者指南

技術棧: rust
領域: backendauthenticationauthorization
議題類型: feature
難度: 3
預計時間: 1-3 hours
活動狀態: active
清晰度: clear
前置要求: Rust programmingbitflags crateMeilisearch codebase overview
新手友善度: 65
研究方向: Start by reviewing the existing key actions implementation in meilisearch types/src/keys.rs. Understand the current 'single numbers' approach and how actions are defined. Read the bitflags crate documentation to learn how to define combinable flags. Then, refactor the Action enum to use the bitflags macro, ensuring all existing action values are preserved. Update any code that compares or uses these action values to work with bitwise operations. Check for tests that need updates. Discuss any breaking changes in the issue comments.