Destroy Menubar · max-mapper/menubar#281

2020-04-27T16:00:39.000Z

[//]: # "Hey there and thank you for using Menubar's issue tracker!" [//]: # "Please fill in these information to describe your issue." ### Description There is no API to destroy a menubar instance. I'm implementing a feature in my application which will allow the end-users to run their Electron app in a tray or a window, but there is no mechanism to tear-down a menubar. ### Steps to Reproduce the Problem 1. Create a menubar 2. Destroy Window Reference 3. `Error: Object has been destroyed: at Menubar. (my-app/node_modules/menubar/lib/Menubar.js:311:72)` ### Expected Behaviour I'd like for the menubar instance to have a teardown function ### Actual Behaviour There is no API to support this ### Specifications - Menubar version: 6.0.8 - Platform: Mac - Electron version: 7.1.9 ### Other information

(1 留言) (2 反應) (0 負責人)TypeScript (365 fork)github user discovery

good first issue

倉庫指標

Star: (6,778 star)
PR 合併指標: (PR 指標待抓取)

描述

Description

There is no API to destroy a menubar instance. I'm implementing a feature in my application which will allow the end-users to run their Electron app in a tray or a window, but there is no mechanism to tear-down a menubar.

Steps to Reproduce the Problem

Create a menubar
Destroy Window Reference
Error: Object has been destroyed: at Menubar.<anonymous> (my-app/node_modules/menubar/lib/Menubar.js:311:72)

Expected Behaviour

I'd like for the menubar instance to have a teardown function

Actual Behaviour

There is no API to support this

Specifications

Menubar version: 6.0.8
Platform: Mac
Electron version: 7.1.9

Other information

貢獻者指南

研究方向: 理解 Menubar 類的生命週期，並實現一個 destroy 方法，該方法能正確釋放 BrowserWindow 和 Tray，移除事件監聽器，並重設內部狀態。
技術棧: typescriptnodejs
領域: desktop
議題類型: 功能
難度: 3
預計時間: 半天
活動狀態: 活躍
清晰度: 清晰
前置要求: ElectronTypeScriptGit
新手友善度: 60