matthewmueller/x-ray

Can't catch an error thrown when there's an invalid status code 522

Open

#90 建立於 2015年9月2日

在 GitHub 查看
 (1 留言) (1 反應) (0 負責人)JavaScript (5,804 star) (415 fork)batch import
bughelp wanted

描述

Hi,

I'm trying to scrape the url below but after some time it shows an error: http://www.lazygamer.net/boost/the-top-10-gaming-youtubers-in-2014-so-far/

assert.js:86
  throw new assert.AssertionError({
        ^
AssertionError: invalid status code: 522
    at Object.status (/Users/jonathan/git/youtube_urls_from_url/node_modules/x-ray/node_modules/http-context/lib/response.js:81:5)
    at context.status (/Users/jonathan/git/youtube_urls_from_url/node_modules/x-ray/node_modules/http-context/node_modules/delegates/index.js:92:31)
    at /Users/jonathan/git/youtube_urls_from_url/node_modules/x-ray/node_modules/x-ray-crawler/lib/http-driver.js:30:20
    at Request.callback (/Users/jonathan/git/youtube_urls_from_url/node_modules/x-ray/node_modules/x-ray-crawler/node_modules/superagent/lib/node/index.js:797:3)
    at IncomingMessage.<anonymous> (/Users/jonathan/git/youtube_urls_from_url/node_modules/x-ray/node_modules/x-ray-crawler/node_modules/superagent/lib/node/index.js:990:12)
    at IncomingMessage.emit (events.js:129:20)
    at _stream_readable.js:908:16
    at process._tickCallback (node.js:355:11)

I also attached a screenshot of the webpage loaded from the browser if it's helpful.

貢獻者指南

技術棧
javascriptnodejs
領域
backend
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
2
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
under 1 hour
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Node.js basicserror handling
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
70
研究方向
The issue occurs when an HTTP status code 522 is encountered, causing an unhandled AssertionError in `http context/lib/response.js` (line 81). The error propagates from x ray crawler's http driver.js via superagent. To fix, consider catching the assertion error or validating status codes before they are passed to the response object. No linked PRs or maintainer comments exist, so investigate whether the assertion should be wrapped in a try catch or the status code should be allowed.