matthewmueller/x-ray

Better Stream Support

開放

#160 建立於 2016年3月26日

 (0 則留言) (2 個反應) (0 位負責人)JavaScript (415 個分叉)batch import
enhancementepichelp wanted

倉庫指標

星標
 (5,804 顆星)
PR 合併指標
 (PR 指標待抓取)

描述

Currently stream support is poor.

I'm doing experiments on my computer and under stream error nothing happens and this is totally dangerous.

Also I've noticed that code is dirty because first, need to handle callback of the requests, and later, handle the stream interaction (that could be a noop method, lol)

It could be more simple just handling the data as stream (Before my experienced creating fetch-timeline, I think that from2 is the right way, maybe JSONStream too) and, if a callback is provided, convert the stream into a callback interaction (for example, using read-all-stream).

This feature/refactor is very important to support filter/transform data with perfomance.

貢獻者指南