mattermost-community/focalboard

Code Debt: Share common code between Person and MultiPerson properties

Open

#4,842 建立於 2022年9月30日

在 GitHub 查看
 (4 留言) (0 反應) (0 負責人)TypeScript (26,187 star) (2,542 fork)user submission
EnhancementHacktoberfestHelp WantedUp for grabs

描述

Summary

The Person Property and MultiPerson Property share most of the same code.

Especially after this PR made them work in an equivalent manner. We should implement a "base Person property" and update Person and MultiPerson to call this property with its specific needs.

How important this is to me and why

Importance: High

As a sameple, see how the various text properties (Text, Email, Phone, and Number) use BaseTextEditor.

貢獻者指南

技術棧
typescriptreact
領域
frontend
議題類型
refactor
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
ReactTypeScriptFocalboard codebase
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
60
研究方向
Examine the files `webapp/src/properties/person/person.tsx` and `webapp/src/properties/multiperson/multiperson.tsx` to understand their shared logic. Review PR #3888 which made them equivalent. Create a base component similar to `BaseTextEditor` and refactor both properties to extend it. Ensure that the refactored components pass existing tests and maintain functionality.