mattermost-community/focalboard

Perf: Drag and drop cards in Kanban board view shows intermediate sort state

Open

#2,315 建立於 2022年2月11日

在 GitHub 查看
 (1 留言) (0 反應) (0 負責人)TypeScript (26,187 star) (2,542 fork)user submission
BugHelp WantedPerformanceSev/3Up for grabs

描述

Steps to reproduce the behavior

  1. Open a board (Kanban) view
  2. Drag a card onto another card in a column with multiple (5+) cards
  3. The card first appears at the beginning or end, then moves to the right position a split second later

Expected behavior

The card should move directly to the dropped position

Screenshots

https://user-images.githubusercontent.com/46905241/153519856-3a0fd910-a008-46d9-bfca-fd1ee70e68d1.mov

Edition and Platform

  • Edition: Mattermost plugin
  • Version: v0.14
  • Browser and OS: Chrome on Mac

Additional context

In the browser network tab, notice that PATCH Block is called twice. This is because on onDropToCard in kanban.tsx, the property change and sort order are two separate API calls. Propose refactoring to call UpdateBlocks in a single call.

貢獻者指南

技術棧
typescriptreact
領域
frontend
議題類型
performance
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
fresh
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
ReactTypeScriptdrag and drop
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
70
研究方向
The issue is in the Kanban view component, specifically the `onDropToCard` function in `webapp/src/components/kanban/kanban.tsx` (line 172). Currently, two separate PATCH API calls are made for property change and sort order, causing a visual glitch. The fix is to refactor to call `UpdateBlocks` once with both changes. Investigate the `UpdateBlocks` function and ensure the batch call handles both fields correctly. Check if there are existing tests for this behavior to validate the change.
Perf: Drag and drop cards in Kanban board view shows intermediate sort state · mattermost-community/focalboard#2315 | Good First Issue