matrix-org/synapse

Third Party Lookups: the returned protocol instance icons are not Matrix Content URIs

Open

#4,175 建立於 2018年11月12日

在 GitHub 查看
 (2 留言) (0 反應) (0 負責人)Python (11,713 star) (2,196 fork)batch import
A-Spec-ComplianceS-MinorT-Defectgood first issue

描述

Contrary to the documentation (https://matrix.org/docs/spec/client_server/r0.4.0.html#get-matrix-client-r0-thirdparty-protocols), the returned protocol icons are not mxc:// URIs. The client gets https URLs (like "https://matrix.org/_matrix/media/v1/download/matrix.org/DHLHpDDgWNNejFmrewvwEAHX").

貢獻者指南

技術棧
python
領域
backendapi
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
mostly clear
前置要求
Basic PythonUnderstanding of Matrix spec
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
70
研究方向
The issue describes that protocol instance icons are returned as https URLs instead of mxc:// URIs. To fix, locate the code in Synapse that handles third party protocol lookups (likely in synapse/rest/thirdparty.py or similar). Ensure that when returning protocol instance icons, the URI is an mxc:// URI as per the Matrix specification. This may involve converting the media URL to an MXC URI using the appropriate media repository API. No linked PRs exist, so the fix is independent.