matrix-org/synapse

Follow the spec regarding /client/r0/keys/changes

Open

#3,058 建立於 2018年4月3日

在 GitHub 查看
 (5 留言) (0 反應) (0 負責人)Python (11,713 star) (2,196 fork)batch import
A-Spec-ComplianceS-TolerableT-Defectgood first issue

描述

Description

Moving the discussion from the spec repo (https://github.com/matrix-org/matrix-doc/issues/1170).

A request to the endpoint will succeed even if it's missing the to query parameter which is marked as mandatory.

Steps to reproduce

curl -XGET "https://matrix.org/_matrix/client/r0/keys/changes?access_token=${TOKEN}&from=${NEXT_BATCH}"

Replacing TOKEN and NEXT_BATCH with a valid access token and a next_batch token returned by sync, respectively.

Expected behavior.

The endpoint should throw an error.

Version information

Tested with synapse v0.26 & with matrix.org

貢獻者指南

技術棧
pythonrest api
領域
backendapi
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
2
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
under 1 hour
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
PythonHTTP APIMatrix specSynapse codebase
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
85
研究方向
Look at the implementation of the /keys/changes endpoint in Synapse (likely in synapse/rest/client/keys.py) to see how 'from' is validated but 'to' is not. Ensure 'to' is treated as mandatory as per the Matrix spec (matrix doc issue #1170). Add necessary validation similar to other required query parameters in the codebase.