matrix-org/dendrite

The transaction_id within events is not serialised in many endpoints

開放

#3,000 建立於 2023年3月6日

 (3 則留言) (0 個反應) (0 位負責人)Go (658 個分叉)auto 404
O-FrequentT-Defectgood first issuespec-compliance

倉庫指標

星標
 (5,632 顆星)
PR 合併指標
 (PR 指標待抓取)

描述

Similar to https://github.com/matrix-org/synapse/issues/15173 in Synapse

There are many endpoints that return events, and in those representations they should include the transaction_id in the unsigned part of the event.

I wrote a Complement test to highlight that Synapse had this issue by testing using the /rooms/{roomId}/event/{eventId} endpoint, and Dendrite also fails on this test. I haven't tested the other endpoints, nor covered them in the Complement test. https://github.com/matrix-org/complement/pull/621

貢獻者指南