matrix-org/dendrite

Move to zerolog

開放

#1,468 建立於 2020年10月2日

 (12 則留言) (4 個反應) (0 位負責人)Go (658 個分叉)auto 404
T-TaskX-Performancegood first issue

倉庫指標

星標
 (5,632 顆星)
PR 合併指標
 (PR 指標待抓取)

描述

We should move to use https://github.com/uber-go/zap or https://github.com/rs/zerolog instead of logrus because logrus does a loooooot of allocations, far more than the rest of Dendrite. I'd propose we use the sugared one since we're not looking for any specific improvement other than "why is logging consuming so much time/allocs". In terms of numbers:

  • logrus 29501 ns/op
  • zap 1250 ns/op (~24x speedup)

Allocations:

  • logrus 125 allocs/op
  • zap 11 allocs/op

貢獻者指南