matomo-org/matomo

IP::getNonProxyIpFromHeader retrieves final proxy instead of client

Open

#7,060 建立於 2015年1月21日

在 GitHub 查看
 (8 留言) (0 反應) (0 負責人)PHP (21,513 star) (2,847 fork)batch import
BugHelp wanted

描述

IP::getNonProxyIpFromHeader attempts to retrieve the client IP address from headers configured in proxy_client_headers[]. This calls IP::getLastIpFromList, excluding proxies configured via proxy_ips[].

What I do not understand is why by default this returns the last IP, whereas the format for X-Forwarded-For is client, proxy1, proxy2, ...: http://en.wikipedia.org/wiki/X-Forwarded-For#Format

This only becomes an issue when running Piwik behind multiple proxies; for example the configuration in question is:

[Enterprise Appliance] => [IIS ARR] => [Piwik]

So Piwik sees:

X-Forwarded-For: <client>, <enterprise_appliance>

Basically the current behavior would seem to select the IP of the last proxy by default. This would be problematic in a scenario with variable proxy IPs.

貢獻者指南

技術棧
php
領域
backend
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
PHPX Forwarded For header formatproxy configuration
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
45
研究方向
Examine the implementation of `IP::getNonProxyIpFromHeader` and `IP::getLastIpFromList` in core/IP.php. Understand the expected format of X Forwarded For (client, proxy1, proxy2). The current code returns the last IP, which is the proxy; it should return the first IP (client). Consider modifying the logic to retrieve the first IP instead of the last, ensuring any proxy IPs are still excluded. Check for any existing tests related to IP handling.