mariogarridopt/json-viewer

Change app icon on dark mode

開放

#2 建立於 2025年7月21日

 (0 則留言) (0 個反應) (0 位負責人)HTML (0 個分叉)auto 404
enhancementgood first issue

倉庫指標

星標
 (0 顆星)
PR 合併指標
 (30 天內沒有已合併 PR)

描述

The current icon for the app is not very well visible on dark mode.

There is a way to change the icon based on the theme of the browser:

   {
     "manifest_version": 3,
     "name": "My Extension",
     "version": "1.0",
     "icons": {
       "16": "icons/icon-light-16.png",
       "48": "icons/icon-light-48.png",
       "128": "icons/icon-light-128.png",
       "16": {
         "theme_light": "icons/icon-light-16.png",
         "theme_dark": "icons/icon-dark-16.png"
       },
       "48": {
         "theme_light": "icons/icon-light-48.png",
         "theme_dark": "icons/icon-dark-48.png"
       },
       "128": {
         "theme_light": "icons/icon-light-128.png",
         "theme_dark": "icons/icon-dark-128.png"
       }
     },
     "permissions": [
       "storage"
     ]
   }

My suggestion is to take the current icon, invert it so that the back and white and add it to the manifest to be used when browser there is dark.

貢獻者指南