mapbox/mapbox-gl-js

v1.10.0-beta.1 - No way to disable new "tap then drag" to zoom gesture

Open

#9,584 建立於 2020年4月17日

在 GitHub 查看
 (1 留言) (4 反應) (1 負責人)JavaScript (10,532 star) (2,203 fork)batch import
feature :green_apple:good first issue

描述

The TouchZoomRotateHandler support various gestures ("zoom rotate", "pinch zoom/touch zoom", "single finger zoom/tap then drag"), however it only allows you to disable the "zoom rotate" gesture.

The individual gestures can be disabled by diving in to the private members (such as by calling "map.touchZoomRotate._tapDragZoom.disable();").

It would be nicer to have a match for disableRotation()/enableRotation() to turn on/off each supported gesture (i.e. add a disableTapZoom()/enableTapZoom()).

貢獻者指南

技術棧
javascript
領域
frontend
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
half day
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
mostly clear
前置要求
Familiarity with Mapbox GL JS APIUnderstanding of gesture handling in WebGL maps
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
60
研究方向
Examine the existing TouchZoomRotateHandler to understand how disableRotation/enableRotation are implemented. Look at the private tapDragZoom property and its disable/enable methods. Consider adding similar public methods disableTapZoom/enableTapZoom following the same pattern. Check for any ongoing discussions in the issue comments or related PRs.