mapbox/mapbox-gl-js

Symbol interpolation issue when icon-pitch-alignment is "map"

Open

#8,110 建立於 2019年4月2日

在 GitHub 查看
 (1 留言) (0 反應) (0 負責人)JavaScript (10,532 star) (2,203 fork)batch import
bug :lady_beetle:good first issue

描述

mapbox-gl-js version: v0.54.0-beta.1

browser: any

Steps to Trigger Behavior

  1. create a symbol layer with icon-pitch-alignment set to "map"
  2. do not rotate or pitch the map

Expected Behavior

Icon should be rendered with NEAREST interpolation

Actual Behavior

Icon is rendered with LINEAR interpolation

Hint: there is a condition in draw_symbol.js:197

pitchWithMap || tr.pitch !== 0

I think it should be just

tr.pitch !== 0

because when icon-pitch-alignment is set to "map", and neither the icon nor the map is rotated, NEAREST should be used. (same as "viewport" alignment)

貢獻者指南

技術棧
javascript
領域
frontend
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
2
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
under 1 hour
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
JavaScriptmapbox gl js symbol layers
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
85
研究方向
The bug is in draw symbol.js at line 197, where the condition `pitchWithMap || tr.pitch !== 0` should be changed to `tr.pitch !== 0`. This ensures NEAREST interpolation is used when icon pitch alignment is 'map' and the map is not pitched. The issue has no linked pull requests, so the fix is straightforward and well documented. Review the symbol rendering code in draw symbol.js to implement the change and verify with a test case.