mapbox/mapbox-gl-js

off('load') then on('load') does not work using setStyle

Open

#10,946 建立於 2021年8月19日

在 GitHub 查看
 (2 留言) (0 反應) (0 負責人)JavaScript (10,532 star) (2,203 fork)batch import
bug :lady_beetle:good first issue

描述

mapbox-gl-js version: v2.4.0

browser: Chrome Version 92.0.4515.159

Steps to Trigger Behavior

Reproduce steps

  1. add Map.on('load', func)
  2. add Map.off('load', func)
  3. add Map.on('load', func2)
  4. call Map.setStyle()

Link to Demonstration

https://jsfiddle.net/tsuzk/6o8m9nad

This should work because of this test

Expected Behavior

The Map.on('load', func2) should get called after Map.setStyle()

Actual Behavior

The Map.on('load', func2) does not get called after Map.setStyle()

Workaround

re-instantiate the map with a new stlye https://jsfiddle.net/tsuzk/6o8m9nad/1/

Other info

  • This occurs on v1.9.0 so it's not a new behavior in v2.

Priority

Low, since there is a proper workaround

貢獻者指南

技術棧
javascript
領域
frontend
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
fresh
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
mostly clear
前置要求
basic JavaScriptunderstanding of event listenersfamiliarity with mapbox gl js API
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
40
研究方向
Investigate the event handling in Mapbox GL JS, specifically how the 'load' event listener is managed when setStyle is called. Start by examining the source code of the Map class in /src/ui/map.js and the event system. The bug report references a test at test/unit/ui/map.test.js around lines 136-151 that expects the behavior to work, but it seems the test might be incorrect or the implementation fails in certain cases. Focus on the on/off methods for the 'load' event and how setStyle triggers the event re fire. Review any linked PRs or comments for additional context.