mapbox/mapbox-gl-js

FeatureLevelRemove- and SourceLevelRemove-Benchmarks in remove_paint_state.js are exactly the same

Open

#10,049 建立於 2020年10月23日

在 GitHub 查看
 (0 留言) (0 反應) (0 負責人)JavaScript (10,532 star) (2,203 fork)batch import
good first issue

描述

Unless I'm missing something, both benchmarks were already the same when they were added in #7761 by @peterqliu :

https://github.com/mapbox/mapbox-gl-js/blob/ff8e087b6e7cc9fe63eb4809a0895b38029a67e2/bench/benchmarks/remove_paint_state.js#L88-L100 https://github.com/mapbox/mapbox-gl-js/blob/ff8e087b6e7cc9fe63eb4809a0895b38029a67e2/bench/benchmarks/remove_paint_state.js#L102-L114

I haven't used these APIs yet, but I believe the SourceLevelRemove should have used something like this?

// No loop
this.map.removeFeatureState({source: 'land'});

Maybe also source-property level like this?

// No loop
this.map.removeFeatureState({source: 'land'}, 'bench');

貢獻者指南

技術棧
javascript
領域
performancetesting
議題類型
test
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
2
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
under 1 hour
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
JavaScriptmapbox gl js API
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
70
研究方向
The issue identifies that the FeatureLevelRemove and SourceLevelRemove benchmarks in bench/benchmarks/remove paint state.js (lines 88-100 and 102-114) are identical, which is likely a copy paste error. The SourceLevelRemove benchmark should use `map.removeFeatureState({source: 'land'})` instead of looping over features. Review the mapbox gl js API documentation for `removeFeatureState` and consider whether a source property level removal (e.g., `map.removeFeatureState({source: 'land'}, 'bench')`) is more appropriate. The fix involves modifying the SourceLevelRemove benchmark function to replace the loop with the correct API call, ensuring it tests the intended functionality. After making the change, run the benchmarks to verify correctness.