lsd-rs/lsd

Add `ls_colors` option to theme

Open

#608 建立於 2022年1月17日

在 GitHub 查看
 (2 留言) (4 反應) (0 負責人)Rust (13,400 star) (434 fork)batch import
area/themegood first issuekind/enhancement

描述

As of now, we support theme for colors, and still use ls_colors for file name colors, how about adding the ls_colors option to the theme configuration file, and so that we can configure all the colors in one place.

also, there is something that needs to be covered:

  1. the ls_colors in the theme should be optional, and fall back to LS_COLORS env
  2. the one in themes should overwrite the env one

@meain

貢獻者指南

技術棧
rust
領域
cli
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
fresh
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Rust programmingFamiliarity with lsd's theme configurationUnderstanding of LS COLORS environment variable
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
75
研究方向
Explore the current theme configuration implementation in the lsd source code, particularly how colors are handled. The issue suggests adding an `ls colors` field to the theme struct (likely in src/theme.rs or similar). Ensure the new option is optional and falls back to the `LS COLORS` environment variable. Check if there are any existing tests for theme parsing that need updating.
Add `ls_colors` option to theme · lsd-rs/lsd#608 | Good First Issue