localForage/localForage

Make "name" optional in config when driver = localstorage

Open

#641 建立於 2017年1月6日

在 GitHub 查看
 (2 留言) (0 反應) (0 負責人)JavaScript (24,184 star) (1,260 fork)batch import
bugdocshelp wantedquestion

描述

I am trying to read key "counter" from localstorage, but can't, because it tries to read "/counter" if I set name to "". If I set name to "whatever" it reads "whatever/counter". Can you change line 20 in localForage/src/drivers/localstorage.js from dbInfo.keyPrefix = dbInfo.name + '/'; to something like dbInfo.keyPrefix = (dbInfo.name && dbInfo.name != "") ? dbInfo.name + '/' : '';

貢獻者指南

技術棧
javascript
領域
frontenddatabase
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
2
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
under 1 hour
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
JavaScriptlocalStorage knowledge
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
80
研究方向
The issue suggests modifying line 20 in localForage/src/drivers/localstorage.js to make the 'name' config optional when driver is localStorage. The fix is to change the line that sets dbInfo.keyPrefix to conditionally append '/' only if name is non empty. After implementing, test with various name values (empty string, undefined, and a valid name) to ensure keyPrefix is set correctly. Also check if there are any existing tests that might need updating.
Make "name" optional in config when driver = localstorage · localForage/localForage#641 | Good First Issue