lobsters/lobsters

Wrong Content-Type in JPEG images

Open

#2,009 建立於 2026年5月2日

在 GitHub 查看
 (2 留言) (0 反應) (0 負責人)Ruby (4,680 star) (961 fork)user submission
buggood first issue

描述

Some avatar images are not loading in Dillo:

This is caused because the Content-Type HTTP header for the images are always set to image/png, despite being JPEG:

% curl -sI https://lobste.rs/avatars/ohrv-16.png | grep -i content-type
content-type: image/png
% curl -s https://lobste.rs/avatars/ohrv-16.png | file -
/dev/stdin: JPEG image data, JFIF standard 1.01, resolution (DPI), density 96x96, segment length 16, comment: "CREATOR: gd-jpeg v1.0 (using IJG JPEG v62), quality = 90", baseline, precision 8, 16x16, components 3

Dillo uses the Content-Type to select which image decoder to use. As it doesn't recognize the JPEG format as a PNG, it complains and ignores the image:

** WARNING **: "https://lobste.rs/avatars/ohrv-16.png" is not a PNG file.

Could you change this behavior to match the Content-Type to the image format?

貢獻者指南

技術棧
rubyrails
領域
backend
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
2
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
fresh
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Ruby
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
85
研究方向
Investigate how avatar images are served in the lobsters Rails application, likely in the avatars controller or a helper. The Content Type is hardcoded as 'image/png' for all avatars. Modify the code to detect the actual image format (e.g., by reading the file header or using a library like ImageMagick) and set the correct Content Type accordingly. Ensure JPEG images get 'image/jpeg' and PNG images get 'image/png'.
Wrong Content-Type in JPEG images · lobsters/lobsters#2009 | Good First Issue