llvm/llvm-project

Decomposition Declaration diagnostic for missing initializer is pretty unclear

Open

#90,107 建立於 2024年4月25日

在 GitHub 查看
 (9 留言) (0 反應) (0 負責人)C++ (10,782 fork)batch import
clang:diagnosticsgood first issuequality-of-implementation

倉庫指標

Star
 (26,378 star)
PR 合併指標
 (平均合併 1天 2小時) (30 天內合併 1,000 個 PR)

描述

Given the following code:

#include <utility>

std::pair<int, double> MyFunc();

void foo() {
    auto [A, B] C = MyFunc();
}

Our diagnostic is just:

<source>:9:10: error: decomposition declaration '[A, B]' requires an initializer
    9 |     auto [A, B] C = MyFunc();
      |          ^
<source>:9:16: error: expected ';' at end of declaration
    9 |     auto [A, B] C = MyFunc();
      |                ^
      |                ;
2 errors generated.
Compiler returned: 1

https://godbolt.org/z/h9zKT5zGe

No compilers are particularly good at this diagnostic, but all the others at least highlight the C as the mistake, whereas Clang's error is pretty opaque/points at the opening bracket.

I'd prefer we move the 'arrow' to the position where the initializer is expected. Additionally, some improved diagnostic wording that highlights what went wrong better would be appreciated.

貢獻者指南