ljharb/qs

Add the ability to enable strict RFC 3986 conformance for decoding as well as encoding

Open

#205 建立於 2017年4月10日

在 GitHub 查看
 (1 留言) (5 反應) (0 負責人)JavaScript (8,015 star) (744 fork)batch import
enhancementhelp wantedparsesemver-minor: new features

描述

To achieve strict RFC 3986 conformance (specifically, '+' in query strings is a LITERAL '+' and not a placeholder for ' ' as per the W3C's URL recommendations, the following is necessary:

qs.parse(s, {
    decoder: (str) => {
        try {
            return decodeURIComponent(str);
        } catch (e) {
            return str;
        }
    },
})

For those of us who prefer strict RFC 3986 conformance, I suggest an option like:

qs.parse(s, {
    format: 'RFC3986',
})

which would be much more concise and not require knowing the implementation details of the default decode function.

貢獻者指南

技術棧
javascriptnodejs
領域
apibackend
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-2 days
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
understanding of RFC 3986basic JavaScriptfamiliarity with qs library
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
55
研究方向
To implement this feature, examine the current decode function in lib/parse.js and add a 'format' option that, when set to 'RFC3986', uses decodeURIComponent for decoding. Ensure that the default behavior (legacy mode) remains unchanged. Consider adding tests in test/parse.js to verify conformance. The issue suggests a concise API, so the solution should be localized to the parse function and its options.