ljharb/qs

RFC 3986 reserved characters missing

Open

#163 建立於 2016年5月10日

在 GitHub 查看
 (5 留言) (0 反應) (0 負責人)JavaScript (8,015 star) (744 fork)batch import
bughelp wantedstringify

描述

stringify is supposed to be implementing RFC 3986 but RFC 3986 specifies reserved characters as:

reserved    = gen-delims / sub-delims
gen-delims  = ":" / "/" / "?" / "#" / "[" / "]" / "@"
sub-delims  = "!" / "$" / "&" / "'" / "(" / ")"
                  / "*" / "+" / "," / ";" / "="

However $ (as pointed out in request#2129) will be encoded as %24. I guess this is a bug?

貢獻者指南

技術棧
javascript
領域
backendapi
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
2
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
under 1 hour
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
needs maintainer response
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
mostly clear
前置要求
understanding of RFC 3986basic JavaScript
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
70
研究方向
Investigate lib/utils.js line 70 to see the current reserved character list in the stringify function. Compare with RFC 3986 section 2.2 to identify missing characters like '$'. Add the missing characters to the regex or condition, then run the test suite and add new test cases for '$' and other missing characters.