linebender/druid

Mutating setters on druid_shell::Window should have `set_` names.

Open

#777 建立於 2020年3月30日

在 GitHub 查看
 (3 留言) (0 反應) (0 負責人)Rust (9,091 star) (567 fork)batch import
help wantedshell

描述

At least including set_resizeable, and set_show_titlebar, although the latter name isn't great. I might change it to something like titlebar_is_visible and set_titlebar_is_visible or something?

Hmm must not have noticed this, but these should be called set_.

Originally posted by @cmyr in https://github.com/xi-editor/druid/pull/773

貢獻者指南

技術棧
rust
領域
desktop
議題類型
refactor
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
1
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
under 1 hour
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
無
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
90
研究方向
Rename mutating setters in druid shell::Window to have `set ` prefix. Specifically, `set resizeable` and `set show titlebar` (or consider renaming `show titlebar` to `titlebar is visible`). Review the discussion in PR #773 for context. The changes are localized to the druid shell crate, likely in the Window struct implementation.