line/armeria

Consider to remove sorting at MeterIdPrefix

已關閉

#2,150 建立於 2019年10月3日

 (10 則留言) (0 個反應) (0 位負責人)Java (863 個分叉)batch import
good first issueperformance

倉庫指標

星標
 (4,552 顆星)
PR 合併指標
 (PR 指標待抓取)

描述

Currently, we sort the micrometer tags at MeterIdPrefix to create Meter ID stably. https://github.com/line/armeria/blob/master/core/src/main/java/com/linecorp/armeria/common/metric/MeterIdPrefix.java#L95-L101

Since I saw this stacktrace from our service’s flamegraph, I would like to consider whether it is avoidable or not. Since it doesn’t have many samples, we can be ignored but because it is not optimal, it would be happy if we can avoid this sort.

貢獻者指南