libre-tube/LibreTube

Video quality limited to screen resolution

Open

#4,255 建立於 2023年7月18日

在 GitHub 查看
 (7 留言) (3 反應) (0 負責人)Kotlin (11,863 star) (599 fork)batch import
bughelp wantedpriority: low

描述

Steps to reproduce

  1. Open a high resolution video and switch quality to higher quality than screen resolution (for eg -if screen resolution is 720p switch to quality higher than 720p like 1080p 1440p etc)

Expected behavior

If switched to a higher quality than screen resolution, it should play it and should not cap it.

Actual behavior

It caps to quality of screen resolution like it plays only 720p according to stats on 720p screen. and sometimes it even plays 500p something in 720p screen when it should play what is selected

LibreTube version

0.16.1

Android version

Android 12 , 8.1

Other details

No response

Acknowledgements

  • I have written a short but informative title.
  • I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open issue.
  • I will fill out all of the requested information in this form.

貢獻者指南

技術棧
kotlinandroid
領域
mobile
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
half day
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
active
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
KotlinAndroid development
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
50
研究方向
Start by locating the video player initialization code in the repository, likely in a file like `PlayerFragment.kt` or `VideoPlayerActivity.kt`. Examine how the quality is selected and check if there is any logic that limits resolution based on screen dimensions. Look for comments or previous commits related to resolution caps. Test with a video that has resolutions higher than screen resolution to confirm the bug. Consider the ExoPlayer library used by LibreTube and how its TrackSelector is configured.
Video quality limited to screen resolution · libre-tube/LibreTube#4255 | Good First Issue